<html>
<head><meta charset="utf-8"><title>LLVM patch review bump · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/LLVM.20patch.20review.20bump.html">LLVM patch review bump</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="210918984"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/LLVM%20patch%20review%20bump/near/210918984" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/LLVM.20patch.20review.20bump.html#210918984">(Sep 22 2020 at 19:22)</a>:</h4>
<p>This patch hasn't gotten any review yet - <a href="https://reviews.llvm.org/D87474">https://reviews.llvm.org/D87474</a><br>
Can someone more familiar with LLVM recommend an additional reviewer for me to ping? I looked at the code owners file, but didn't see anyone for the area I modified</p>



<a name="210919344"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/LLVM%20patch%20review%20bump/near/210919344" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/LLVM.20patch.20review.20bump.html#210919344">(Sep 22 2020 at 19:25)</a>:</h4>
<p>For reference, this fixes the soundness issue <a href="https://github.com/rust-lang/rust/issues/76387">https://github.com/rust-lang/rust/issues/76387</a></p>



<a name="210920419"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/LLVM%20patch%20review%20bump/near/210920419" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tmandry <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/LLVM.20patch.20review.20bump.html#210920419">(Sep 22 2020 at 19:34)</a>:</h4>
<p>pinged some folks who might know. <span class="user-mention" data-user-id="133224">@Nikita Popov</span> might also know</p>



<a name="210934103"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/LLVM%20patch%20review%20bump/near/210934103" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tmandry <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/LLVM.20patch.20review.20bump.html#210934103">(Sep 22 2020 at 21:34)</a>:</h4>
<p><span class="user-mention" data-user-id="125294">@Aaron Hill</span> here's what I heard back:</p>
<blockquote>
<p>Normally I <code>git blame/log</code> relevant files and see what names frequently come up as reviewers/committers. For that patch, maybe <code>rnk</code> would be a good reviewer?</p>
</blockquote>



<a name="210951637"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/LLVM%20patch%20review%20bump/near/210951637" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/LLVM.20patch.20review.20bump.html#210951637">(Sep 23 2020 at 01:50)</a>:</h4>
<p><code>arc cover</code> can do it for you.</p>



<a name="210975450"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/LLVM%20patch%20review%20bump/near/210975450" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mati865 <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/LLVM.20patch.20review.20bump.html#210975450">(Sep 23 2020 at 08:59)</a>:</h4>
<p>It's a shame <code>arc</code> requires PHP on user's machine</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>